For me it’s definitely been a helpful skill, it makes working with engineers much easier and can sometimes give you more control over delivery.
But I still don’t think ALL designers should code, but I think at least one designer on a design team should code.