I feel clever subbing `return await fn()` with `return fn()`
But gotchas don't seem worth it anymore
• Breaks try/catch/finally expectations
• Loses stack trace context
My default is now to always await. Change my mind.
Ian Macartney
@ianmacartney.bsky.social
74 followers 24 following 61 posts
Friendly engineer at Convex.dev
![let textSearchMessages: Doc<"messages">[] | undefined;
if (args.text) {
textSearchMessages = await ctx.runQuery(api.messages.textSearch, {
userId: args.userId,
threadId: args.threadId,
text: args.text,
limit,
});
}
if (args.vector) {
const dimension = args.vector.length as VectorDimension;
if (!VectorDimensions.includes(dimension)) {
throw new Error(`Unsupported vector dimension: ${dimension}`);
}
const vectors = (
await searchVectors(ctx, args.vector, {
dimension,
model: args.vectorModel ?? "unknown",
table: "messages",
userId: args.userId,
threadId: args.threadId,
limit,
})
).filter((v) => v._score > (args.vectorScoreThreshold ?? 0));
// Reciprocal rank fusion
const k = 10;
const textEmbeddingIds = textSearchMessages?.map((m) => m.embeddingId);
const vectorScores = vectors
.map((v, i) => ({
id: v._id,
score:
1 / (i + k) +
1 / ((textEmbeddingIds?.indexOf(v._id) ?? Infinity) + k),
}))
.sort((a, b) => b.score - a.score);
const vectorIds = vectorScores.slice(0, limit).map((v) => v.id);
const messages: Doc<"messages">[] = await ctx.runQuery(
internal.messages._fetchVectorMessages,
{
userId: args.userId,
threadId: args.threadId,
vectorIds,
textSearchMessages: textSearchMessages?.filter(
(m) => !vectorIds.includes(m.embeddingId!)
),
messageRange: args.messageRange ?? DEFAULT_MESSAGE_RANGE,
parentMessageId: args.parentMessageId,
limit,
}
);
return messages;
}
return textSearchMessages?.flat() ?? [];](https://cdn.bsky.app/img/feed_thumbnail/plain/did:plc:bjnfjbytpwb2w7xlge775hwd/bafkreigvscvz7oymepul3uakdbx5y73hnun4lw2eifhp6coye6m3oko4iy)
